Make it possible to create a DcrawSettingsWidget with only a QWidget as parameter (again :)

Use the file descriptor based method to download a file with gphoto2. This should solve problems with very large files because they can directly be written to disk.

BUG: 174586

Do not create / draw the cursor on every mouse move. The drawing of the mask is a little bit faster now, but still it flickers with cursor-sizes above 64px.

people might have older exiv2 versions installed - do not use newer API before that

More performance fixes: Do not call repaint() directly, ever… in most of the cases we don’t need this. This greatly improves performance on my machine.

Use the oldest of ctime, mtime when falling back to the file system to determine the creation date

CCBUG: 199967

Prepare to use CollectionScanner/Imagescanner to rescan files (“Read metadata to database”)

• so that a manual rescan uses 100% the same code as an initial scan when the file is imported Add a flag to CollectionScanner::scanFile to signal if a normal scan, a scan as if modified or a full rescan shall be done. Some internal restructuring.

CCBUG: 193616

add support of Captions author properties. For each language alternative caption values, user can fill caption author name A caption date properties is also set accordingly, using current date when caption is enter. These new Captions properties are recordrd to datase only, for the moment. TODO: record all captions properties to digiKam XMP namespace CCBUGS: 135476

http://websvn.kde.org/?view=rev&revision=996339

speed up drawing of the mask a little bit, do not convert the DImg to a Pixmap all the time.

I would suggest to display the draw cursor all the time, so it is easier to set the correct size in the panel. Right now we show the cursor only when pressing the mouse.

One question: Why do we allow to set a size of 100 in the panel for the brush size, but disallow the maximum size in the mouseMoveEvent? In there we only allow a max size of 64, which looks weird, because the mask “blob” we draw is bigger as the cursor.

Is this some old, “wrong” code?

Andi

CCMAIL:digikam-devel@kde.org

call update() instead of repaint() whenever possible

Save/restore Captions properties to/from digiKam XMP namespace. Authors and Dates roperties are saved in alternative language bags. Captions Map is build using all these properties, plus the comments get from standard XMP tags.

Marcel, When i import a new image with these XMP metadata into collection, authors and dates map are not imported in database… CCBUGS: 135476 CCMAIL: marcel.wiesweg@gmx.de

Fullscreen is a toggle action and should be used as such. Either press the button in the toolbar, or CTRL+SHIFT+F to exit fullscreen. This mechanism is used throughout KDE and should be used in digiKam as well of course. I would strongly recommend NOT to use ESC to quit the fullscreen mode.

I disable these actions for now, but again I would rather remove it completely. What do you think?

Andi

CCMAIL:digikam-devel@kde.org

Use global action for closing the tools in the image editor. Sometimes the assigned shortcut is not working, which is weird. It doesn’t seem to work so well to assign a shortcut manually to a button. With this global action all the tools will close fine. Also with this method the shortcut becomes configurable.

Add new widet to edit text (based on KTextEdit) which display a click message as with KLineEdit. This improve usability and make interface more easily to understand. This widget will be moved in libkexiv2 later, with others widgets hosted by Template code.

Close tools by pressing ESC. We used ESC in the editor window to get out of fullscreen, but this is inconsistent within digiKam itself as well as throughout the whole KDE desktop. Fullscreen is a toggle action and should be used as such. By re-assigning ESC to the cancel button in the EditorToolSettings, we can now easily abort a filter, which greatly improves usability and is also a often asked feature.

Oops, committed the wrong branch. The commit before was some experimental code. This patch will fix the closing of the tool when a filter is aborted.

set checkspelling language accordingly with settings

Use common method to retrieve copyright information (this now includes the IPTC legacy fields as well)

I think the different scanning code paths are consolidated now, but I need to review tomorrow. Hope no regressions introduced.

DMetadata:

• add a method to fill the copyright-related fields of a given Template
• add a convenience method to convert an AltLangMap passed as QVariant. ImageScanner:
• code from scanImageCopyright has now been moved to DMetadata and ImageCopyright

Put code to read and write from template into ImageCopyright. May be reused.

In ImageScanner, rely on DMetadata::getImageComments to handle all interpretation of comment values. No custom code here.

CCBUG: 135476

new widget to config metadata tags to display on EXIF, IPTC, and XMP view It will be used in setupMetadata panel. CCBUGS: 126086

Get IPTC Core subject codes from XMP or Iptc. Add a method getIptcCoreSubjects which returns subject from XMP or IPTC. Some internal restructuring.

Add a method to abort all current activity and suspend scanning. When the database is changed, all scanning tasks should better be aborted.

Suspend all running scanning tasks before changing the database. Throw in a few wait cursors for the code of opening a new database. May take 1-2secs.

Use CollectionScanner/ImageScanner to read metadata from file to database. This means that this method now uses 100% the same code as if the image was completely unknown so far and newly added to the collection.

So this method can now be used if

• any metadata was changed by external tools
• a missing piece or bug in our scanning code filled wrong or incomplete info in the db

BUG: 135476

optimize

added tooltip

make year locale aware CCBUG:196888

When messing with pointers, always check if they are valid. This gives another backtrace now, which seems to confirm my guess that the libjpeg update is responsible for the crash.

CCBUG:200159

Implement metadata tags filter settings and rules for metadata viewer from right side bar. In setup metadata dialog page, a new panel is available to set which metadata tags must be displayed in EXIF, Makernotes, Iptc and XMP viewer. This panel list all tags supported by Exiv2. User can search on whole tags collection supported with a search bar to found easily metadata title to select. Buttons can clear selection, select all, or use Human Readable default list of tags.

Added Metadata Tags filter support to Showfoto BUGS: 126086

Fix crash when saving images in .tiff format

handle new XMP namespace with right exiv2 version

Remove bold tags from descriptive text in setup pages

support new XMP namespace

Actually save the selected album path in the config.

Following hint from other KDE commit to make this work with libjpeg7. Untested with libjpeg 7. only with libjpeg 6.2, where numerator and denominator are always 1 so the effect is the same.

fix memory leaks

little speed improvement: don’t connect the slots at the beginning of readSettings()

remove some Q3support classes. We still have Qt3 classes in this plugin, which is really bad. Other things to fix: drag & drop

This can’t be right: the urlList of the sharedData is always appended. Every click on “Start Slideshow” will duplicate the list content.

Use QPointers when showing modal dialogs via exec(), as discussed in http://www.kdedevelopers.org/node/3919

use sharedData->urlList in slotSlideShow(), now the selected images are displayed correcly.

fix showSelectedFilesOnly: don’t save this value in the config file, chances are that the radiobutton is always disabled, even if a valid selection is made. Add a different logic: If only one image is selected, assume to display the whole album content, otherwise enable showSelectedFilesOnly and display the selected images.

Increase the maximum slideshow delay to 20s, some users might want to have more…

Fix loading of the saved delay value from the config file. The value was actually saved correctly, but not used properly. This commit should have fixed this.

BUG:200647

Do not crash if imagemagick is not installed BUG:168243

Metadata Filter : if metadata tags from filter are not available in image, show tags as “unavaialble” as well instead is hide it. This will improve usability to compare image metadata.